Project

General

Profile

Feature #702

[PATCH] automatically connect/disconnect on network status changes (w/ KDE)

Added by sebas over 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Quassel Client
Target version:
Start date:
05/23/2009
Due date:
% Done:

100%

OS:
Any

Description

With this patch, my quasselclient automatically connects and reconnects depending on Solid's status. So when my network comes up, quasselclient automatically reconnects to the core, so I don't have to do this manually. It's a feature for those linking against KDE.

I've built-tested it without and it seems I didn't do any harm there. If anyone could have a look if the user interaction is still OK for monolithic client/core, that'd be nice.

quassel-solid-networking-reconnect.diff View (2.36 KB) sebas, 05/23/2009 12:58 AM

quassel-solid-networking-reconnect-fix.diff View (2.43 KB) bbigras, 06/27/2009 09:25 AM


Related issues

Related to Quassel IRC - Bug #735: Quassel does not reconnect after suspend/resume Resolved 07/03/2009

Associated revisions

Revision f9f7524c (diff)
Added by Manuel Nickschas almost 8 years ago

Actually make the client/core connection settings do something

This introduces ping timeout settings and automatic reconnect. If you're using
KDE, you'll get Solid support to disconnect and reconnect as your network connection
status changes.

Thanks to sebas for the initial patch for Solid support!

Closes #405, closes #702

History

#1 Updated by bbigras about 8 years ago

This feature is a must when used with KDE.

I normally use quasselclient with a core on a server. I tried this patch with the monolithic client and when the Internet connection went back on, "showCoreConnectionDlg(true)" make the monolithic client act like quasselclient, it connected to the core on my server.

I added a check to make it work only with the quasselclient.

For the monolithic client I think it could kill every connection when the Internet connection drop and when it come back on it could reactivate every connection with the "Automatic Reconnect" option activated.

#2 Updated by DeepDiver about 8 years ago

Well a similar feature has bee requested by a debian user as well:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=536335

THX

Tom

#3 Updated by Sputnick about 8 years ago

  • Status changed from New to Assigned
  • Assignee set to Sputnick
  • Target version set to 0.5.0
  • % Done changed from 90 to 50
  • Estimated time deleted (1.00 h)

Working on this now. I will probably couple this with a more sensible CoreConnectionDialog and add something for monolithic Quassel (probably a general online/offline mode thing that the various parts of Quassel could react to).

Thanks for the input so far!

#4 Updated by Sputnick about 8 years ago

  • Target version deleted (0.5.0)

#5 Updated by Sputnick almost 8 years ago

  • Target version set to 0.6.0

#6 Updated by brot almost 8 years ago

:) I have just applied the patch and recompiled quassel. Everything works as expected. As i use my laptop at my university and have to change rooms often i am happy that quassel now reconnects automatically. Thanks for the patch!

#7 Updated by Sputnick almost 8 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 50 to 100

Also available in: Atom PDF