Project

General

Profile

Bug #290

Sanitize input of UserInputHandler::handleJoin

Added by xAFFE over 15 years ago. Updated over 15 years ago.

Status:
Resolved
Priority:
High
Assignee:
Sputnick
Category:
Quassel Core
Target version:
0.3.0
Start date:
Due date:
% Done:

0%

Estimated time:
Version:
0.13.1
OS:
Any

Description

If users put whitespaces between the channels in /join statements the core crashes.

Additional information:

Attached is a patched to fix the behaviour.

userinputhandler.patch (1.65 KB) userinputhandler.patch admin, 08/18/2008 02:41 PM
userinputhandler-2.patch (884 Bytes) userinputhandler-2.patch admin, 08/18/2008 03:09 PM

Associated revisions

Revision 6848967a (diff)
Added by Manuel Nickschas over 15 years ago

Don't try to workaround QSystemTray's not being able to close its bubble on Mac

Displaying an empty bubble with 1ms timeout to force the bubble to close on re-activation
does not work on Mac either. Please let me know if there are problems with that on X11 as well.

Fixes BR #290.

History

#1 Updated by xAFFE over 15 years ago

This doesnt work since the keys are also seperated by ,. So if you do /join #chan1, #chan2, #chan3 key1, key2 this wont work. EgS proposed to do s/, +/,/ on the msg string to sanitize it.

The attached patch does this.

Also available in: Atom PDF